search

humanmade / WPThumb

:warning: UNMAINTAINED :warning: On demand image resizing for WordPress
https://humanmade.co.uk/wpthumb/
170 stars 32 forks source link

Filter `get_home_path()` #136

Open MaximeCulea opened 7 years ago

MaximeCulea commented 7 years ago

Hig Guys,

First issue of the year ! 🎉 😄

Here is my special config :

Two things to report :

  1. Got the following issue generated by get_home_path() : https://github.com/humanmade/WPThumb/blob/master/wpthumb.php#L85 As I am under composer the returned ABSPATH is customized /home/clients/aa5c7b1c4826532ba2df6960d2f3404d/web/my-site.fr/public_html/wp/ and will not match /home/clients/aa5c7b1c4826532ba2df6960d2f3404d/web/my-site.fr/public_html/content/uploads/sites/5/2016/06/couv-Rubrique-Regions-ORDI.jpg for replacement.

  2. In getFileURLForFilePath() : https://github.com/humanmade/WPThumb/blob/master/wpthumb.php#L586 home_url() will not return the main domain url but the current blog url. Which for media urls is not good : mysite.fr/inside-pf/16-en/content/uploads/2016/06/couv-Rubrique-Regions-ORDI.jpg unstead of https://bnppp.devbea.fr/content/uploads/sites/5/2016/06/couv-Rubrique-Regions-ORDI.jpg.

Maybe you already have encountered this, but for now I had to hack the plugin. I am asking you if it's possible to add two filters for possibility to change theses values.

Thank you

rmccue commented 7 years ago

Hi @MaximeCulea. We no longer maintain WPThumb, as we now use Tachyon instead.

I'll leave this issue open in case anyone wants to pick it up in the future, but you're best off finding another solution. :)