search

humanmade / WPThumb

:warning: UNMAINTAINED :warning: On demand image resizing for WordPress
https://humanmade.co.uk/wpthumb/
170 stars 32 forks source link

WordPress 3.5 Refactor/rewrite #40

Closed joehoyle closed 11 years ago

joehoyle commented 11 years ago

This isn't ready to go yet, is functional with backgroundFill for solid colours. Still needed:

  1. backgroundFillAuto
  2. Watermarking
  3. Crop from position
davemac commented 11 years ago

Hi there, thanks for all the great work so far. Just wondering how the 3.5 refactor/rewrite is coming along?

joehoyle commented 11 years ago

Hey @davemac I have been running it on 3.5 sites and all seems to be good. However, with teh 3.5 rewrite I have removed a couple of features.

  1. Animated GIFs now receive no special treat, they are auto converted to PNGs (first frame only)
  2. Background fill auto is not yet implemented, only background fill solid
  3. Watermarking needs a little more work
  4. Currently Watermarking and background fill are only supported by GD, though all other WP Thumb functionality will supports Image Magick where WordPress will use it!

If you don't use watermarking or background fill, feel free to test this!

davemac commented 11 years ago

Thanks Joe. I've done some limited testing and one thing I have noticed is that the crop radio buttons are not aligned properly, instead they are presented in a single column as per screenshot attached.

Screen Shot 2012-12-17 at 9 26 24 PM

It looks like /wp-admin/load-styles.php is doing this;

.compat-item .field input { width: 100%; margin: 0; }

If you remove the width:100% then it fixes it.

joehoyle commented 11 years ago

Ahh I think @mattheu has fixed this in master is that right @mattheu ?

mattheu commented 11 years ago

Yes this is be fixed in master.

You could cherry pick the commits:

1b96f91e80893e232c677ff135b8e01afcf01cb9 9a339db1091da667030fa2530987f4c0807893c3

joehoyle commented 11 years ago

Merging!