search

humanmade / WPThumb

:warning: UNMAINTAINED :warning: On demand image resizing for WordPress
https://humanmade.co.uk/wpthumb/
170 stars 32 forks source link

Add "img" shortcode #56

Closed joehoyle closed 11 years ago

joehoyle commented 11 years ago

This adds a new [img] shortcode to be used on post_content like so:

[img http://www.google.com/logo.png width=25 height=25]

One call also pass attachment IDs:

[img 6574 width=25 height=25 crop=1]
joehoyle commented 11 years ago

Thoughts @willmot @mattheu

willmot commented 11 years ago

We should probably go with wpthumb as the shortcode, other plugins might already use img

mattheu commented 11 years ago

As much as I would like [img] - I think it has to be [wpthumb]

bassscape commented 11 years ago

I'm just starting to find my way around GitHub and wanted to ask if there is a way of knowing if the WPThumb branch with the image shortcode will become part of the master? Using the a shortcode could be good for some users.

joehoyle commented 11 years ago

@bassscape if the pull request is not merged yet, then it means it isn't in the master branch - however you can clone this repo and checkout this branch and run from that if you want to give using the shortcode a go. If you do, feedback welcome :)

bassscape commented 11 years ago

@joehoyle Thanks. I guess I was asking if if you have any intentions of merging this branch into the master. I have been using the shortcode a bit over the past day or so, it works well. I have experimented with adding an additional attribute for a defining a class (for alignment of the image), this seems important to me. Other than that my only reservation is that I feel while the shortcode works well for me, other end users might prefer to see the actual image in the visual editor rather than a shortcode - sure this would be a barrier for some end users. Basically I think it's a good addition to the plugin for those who are aware of it and want to use it.

joehoyle commented 11 years ago

Ok, let's change this to [wpthumb] shortcode, and launch