wp-test-lib submodule missing, makes submodule recursive update/init fail

[bakaburg1]

Hi,

When I try to update all my project submodules, when it reaches the https://github.com/scribu/wp-tests-lib.git submodule of WPThumb the process asks for some user and pass. Putting the wrong one makes the process to fail, so I have to init/update all submodules on the same level manually. Going to https://github.com/scribu/wp-tests-lib.git shows a Not Found page.

[joehoyle]

Waiting to hear back from @scribu https://twitter.com/joe_hoyle/status/345645800145186816 I we weren't supposed to use that submodule maybe!

[scribu]

Sorry for the breakage. When I saw you guys forking it and making changes, I just reacted.

You should really be using the wp scaffold plugin-tests command instead (particularly the latest iteration: wp-cli/wp-cli#513).

It generates all the supporting files needed, without having to rely on submodules. Example: https://github.com/wp-cli/sample-plugin

Let me know if you have any questions about it.

[joehoyle]

@scribu ahh ok no worries, as that was linked to from @benbaltar's repo thought that was the canonical source! So, I set up with wp-cli which is awesome, thanks very much!

@willmot you'll want to update backupwordpress too maybe?

[joehoyle]

Merged, should be sorted now @bakaburg1

[scribu]

ahh ok no worries, as that was linked to from @benbaltar's repo thought that was the canonical source!

Yeah, it wasn't very clear that it was deprecated. I updated the readme: https://github.com/benbalter/wordpress-plugin-tests

[bakaburg1]

uhm... "git submodule update --recursive" still blocks on "Cloning into tests/lib..." with a credentials request.

Probably I'm missing something! (To be noted: I just started with git, so i'm quite inexperienced)

[joehoyle]

@bakaburg1 you will need to pull the latest WPThumb into your project:

> cd /path/to/wpthunmb
> git pull

Then commit the new submodule ref to your project. git submodule update --init --recursive will try and pull WPThumb from the old submodule reference (which includes the testing lib)

[bakaburg1]

Ok it works!! But there is a problem though. My WPThumb module is inside another module, https://github.com/noeltock/prometheus and I have a tree like this eg: home --- prometheus ------ WPThumb

So I suppose it's necessary for the prometheus project to upgrade too.

[scribu]

Indeed; you should commit the new WPThumb submodule revision to Prometheus and open a pull request.

[bakaburg1]

Can try, maybe i'm not the most experienced and indicated persone to do that :)

[joehoyle]

I'll ping @noeltock of prometheus fame, ping @noeltock!

[scribu]

I just remembered that I caused similar grief when I moved the repo from scribu/wp-tests-lib to AppThemes/wp-tests-lib (Github didn't have automatic redirects back then). Long story short, scribu/wp-tests-lib is back up, with a proper deprecation notice.

That said, Prometheus should still be updated.

[noeltock]

I updated it, just can't keep an eye on every commit made.

[bakaburg1]

Thanks!

[scribu]

Thanks, Noel.

just can't keep an eye on every commit made.

Exactly! That's why I'm keeping my old repo around, so that people can move away from it at their own pace.