Closed ghost closed 10 years ago
Assigned to me to review
A fallback to solid fill needs to be added if no or invalid tile image was provided.
Example image with tiled background fill:
@daankortenbach how do you feel about making unit tests for this?
@joehoyle I was already looking into it. Can't promise any dates though.
I think this would probably be better as a WP Thumb addon plugin, as I think the functionality is not "mainstream", you can hook into wpthumb_image_post
and subclass WP_Thumb_Background_Fill
to make this pretty lightweight I'd think. Re-open if needed :)
Agreed, it's an edge case anyway.
Extends
background_fill
with an extra argumenttile
.Usage: Set
background_fill
totile
(egbackground_fill=tile
) andtile
to an image path or url (eg `tile=http://domain.ext/image.jpg).Example:
Please review before adding. Works for me but was coded quite fast.