Closed noeltock closed 2 years ago
Assigning to @roborourke for review
Looks good overall. I'd like to go deeper on some items though, and also to get clarity on what is shippable right now to avoid questions / confusion.
Some of the questions below can perhaps be answered on the specific issues rather than here.
To that end:
Also:
What links will we have under the author avatar & name
We have no special actions for now (as the features aren't there to go clickthrough to). So I think Edit, Duplicate, Archive is it — however Duplicate/Clone doesn't exist as functionality yet, so that could be backlogged (and simply ship Edit/Archive).
What is the UI once "Add new" is clicked
Good shout, I'll get that designed/mocked-up, but will be a dropdown of content types (Post, Page, Block, etc)
After the content type there is text like "Spring Promo", what is the source of that
"Spring Promo" specifically was exploratory design, apologies for including that — it reflects a potential future where we have another Campaign layer/feature. That aside, open to thoughts, but my idea was:
PAGE / SERVICES
POST / 17D OLD
REUSABLE BLOCK
// this is where Campaign can come in as secondary meta here in the futureThere are only positive percentage change indicators shown, what does the opposite look like
Snap, will get that done, cheers.
Are there hover/focus states
Nothing exotic, if I have time, I'll get the designs to reflect the subtle changes in colour for hovers.
Does the hero chart show uniques or total page views, should we show both?
Uniques, this was a Greece convo, but the assumption being that we want to start with Users as that's the currency of DXP's, so we're helping frame/prime our users to actual visitors as opposed to a supply of pageviews. Regarding doing both, we discussed our users having to request that from us (i.e. we start small). Once we get there, there'll be additional design work too (shadow line, secondary line, etc.).
How would pagination look like for the table items. Shall we stick with what we currently have ?
Yeah, let's roll with that for now 👍🏻 Ping in Slack if you need advice/thoughts on the fly. Cheers!
So I think Edit, Duplicate, Archive is it — however Duplicate/Clone doesn't exist as functionality yet, so that could be backlogged (and simply ship Edit/Archive)
"Archive" isn't language used by default in WP anywhere with regards to content, at least in english language packs. Would that be equivalent to "Trash"? Although I do prefer the term "Archive" to "Trash" it'd be better to match default WP terminology.
Cheers for the other clarifications.
Assigning back to @noeltock to progress as per convo.
Remaining from the tasks outlined in OP is the meta header and welcome text.
- The scaffolding includes a meta header which has logo, our own navigation (external links) and current release version).
- Welcome text (as per design) with link to Widget Dashboard.
Other notes:
Add new
design has been implemented in basic format, can create a new issue if the design incorporates how it should look like. And it currently references all post types coming from the backend.
This issue is for the Dashboard, comments: