search

humanmade / altis-cloud

Cloud Module for Altis
https://docs.altis-dxp.com/cloud/
9 stars 2 forks source link

add note for log retention #851

Closed owaincuvelier closed 4 months ago

mikelittle commented 4 months ago

@owaincuvelier Did you mean to raise this against v18-branch? Would it be better as a PR against master, with labels added to backport to all the supported versions?

mikelittle commented 4 months ago

@owaincuvelier This change is good but, as per my comment, it aplies to all current versions. So the PR should be made against the master branch and the backport labels added for all the current versions.

mikelittle commented 4 months ago

@owaincuvelier I switched this to be against master, but some additional changes are showing up. I don't know if that is because your v18-branch was out of date. Or you need to rebase your branch against master.

owaincuvelier commented 4 months ago

@mikelittle my bad! I'll close this PR and just reopen it.