search

humanmade / altis-cloud

Cloud Module for Altis
https://docs.altis-dxp.com/cloud/
9 stars 2 forks source link

Fix < php 8.0 #859

Open joehoyle opened 4 months ago

joehoyle commented 4 months ago

Union return type was only added in 8.0. So this fails the hm-linter checks

joehoyle commented 3 months ago

ping @kovshenin to get the project green

mikelittle commented 3 months ago

Is this necessary? Altis master doesn't support PHP < 8.0 Is the fix to configure the automatic lint to check against PHP >= 8.0

joehoyle commented 2 months ago

Is the fix to configure the automatic lint to check against PHP >= 8.0

Ideally yes, though HM Linter is blocked on https://github.com/humanmade/linter-bot/pull/162

If we dont want to merge this, I'd suggest we move away from HM Linter and run PHPCS in github actions instead.