humanmade / altis-cloud

Cloud Module for Altis
https://docs.altis-dxp.com/cloud/
9 stars 2 forks source link

`esc_html` is not safe for exception handling in wp-redis #866

Open roborourke opened 3 months ago

roborourke commented 3 months ago

This is a bug inherited after merging the upstream changes to wp-redis to our fork.

Issues on the pantheon repo:

PR merged on upstream repo:

We need to merge the upstream changes again, release and update the cloud module.

If we're not maintaining any of our own changes to the upstream version any more, or if we only forked it to publish to packagist, I would suggest we change Altis to include the upstream as a dependency now that Pantheon have published it https://packagist.org/packages/pantheon-systems/wp-redis

After discussion, it looks like there is no longer any need to keep the HM fork.

Acceptance Criteria


For Altis Team Use

Ready for Work Checklist

Is this ticket ready to be worked on? See the Play Book Definition of Ready

Completion Checklist

Is this ticket done? See the Play Book Definition of Done

mikelittle commented 3 months ago

I added to refine and must have labels. We need to check we are ok to switch to the upstream version, or, if we are changing it in some way, incorporate the bug fix.

mikelittle commented 3 months ago

Hey team! Please add your planning poker estimate with Zenhub @ferschubert-hm @jerico @wisyhambolu @kovshenin