search

humanmade / altis-cms

CMS Module for Altis
https://www.altis-dxp.com/resources/docs/core/
46 stars 5 forks source link

Simple Local Avatars TypeError in PHP8 #692

Open mattwatsoncodes opened 1 year ago

mattwatsoncodes commented 1 year ago

This line produces an error in PHP8:

https://github.com/humanmade/altis-cms/blob/d8348f185961f3f6faf7c1e436f2ca468b2c80de/lib/simple-local-avatars/includes/class-simple-local-avatars.php#L928

TypeError: Unsupported operand types: string + int

Using is_numeric instead of the additional of a 0 and is_int fixes the error.

PR raised in 10up repository to fix this issue:

https://github.com/10up/simple-local-avatars/pull/183

owaincuvelier commented 1 year ago

hey @mattwatsoncodes, just to let you know this is getting fixed in: https://github.com/humanmade/altis-cms/pull/695