search

humanmade / altis-cms

CMS Module for Altis
https://www.altis-dxp.com/resources/docs/core/
46 stars 5 forks source link

Fixes CodeCeption tests #838

Closed wisyhambolu closed 5 months ago

wisyhambolu commented 5 months ago

TESTS ON LOCAL

Acceptance Tests (2) ---------------------------------------
✔ SignupsCest: Test I want to manage my network signups. (14.03s)
✔ SiteCest: Test I want to manage my network sites. (43.03s)
------------------------------------------------------------

Time: 01:25.397, Memory: 22.00 MB

OK (2 tests, 3 assertions)
Flushing the cache...
Removing test databases..

What's next?
  Try Docker Debug for seamless, persistent debugging tools in any container or image → docker debug test-root-db
  Learn more at https://docs.docker.com/go/debug-cli/
Removing headless browser container..
kovshenin commented 5 months ago

Change looks fine. I agree re. long tests though, I think it's worth removing rate limiting in Local Server, it is not useful at all.

joehoyle commented 5 months ago

We can override the rate limits in the nginx container per https://github.com/humanmade/docker-wordpress-nginx/blob/master/docker-entrypoint.d/config-replacements.sh, we'd need to just define the env vars in https://github.com/humanmade/altis-local-server/blob/master/inc/composer/class-docker-compose-generator.php#L337

wisyhambolu commented 5 months ago

Thanks for the feedback everyone, I'll create a PR to override the rate limits in the nginx container.

wisyhambolu commented 5 months ago

Closing in favour of https://github.com/humanmade/altis-local-server/pull/698 and https://github.com/humanmade/docker-wordpress-nginx/pull/96