Ensure the consent overlay is clickable.

[robindevitt]

Issue

The clickable areas for the cookie category overlay does not align with the displayed checkboxes and labels. Original Issue #991

Solution

This PR ensure the consent overlay is clickable by setting the conflicting div to position relative.

Steps to confirm

1. Go to Any page on the site with out cookies set up so the Consent popup appears
2. Click on Cookie Preferences
3. You should now be able to click any of the check boxes & the labels

Screenshare

https://user-images.githubusercontent.com/16571365/161746867-bfe9cc7c-6202-4560-81f0-de414f0e7b4e.mov

[robindevitt]

Shall I clean up the HM Linter changes too despite not being related to this issue? Most of them look pretty straight forward except for the one where the "Expected nesting depth to be no more than 2 (max-nesting-depth)", that change may be a bit more indepth.

[roborourke]

I'd make a separate PR to clean up the linter errors I think, they're all on the minified CSS file and HM Linter seems to not work with .stylelintignore files so we'd need to see if the build tools can add a line like /* stylelint-disable */ to the start of the built CSS file.

[roborourke]

Were you able to replicate the issue on the theme in your video? Also did you test this fix with the twenty twenty two theme used in @mikelittle's video?

[robindevitt]

Were you able to replicate the issue on the theme in your video? Also did you test this fix with the twenty twenty two theme used in @mikelittle's video?

I was able to replicate it with Twenty Nineteen. I tried now and replicated and confirmed the fix with Twenty Twenty Two ( video added below ).

https://user-images.githubusercontent.com/16571365/161752828-117bd2c2-849b-4e51-8950-44b341af457b.mov

[roborourke]

Also apologies - I thought you were only referring to the linter errors from the built files, I would at least fix up the errors in the code you added / changed here e.g. changing "0px" to just "0" without units.

[robindevitt]

HM Linter bot changes/fixes have been implemented to the built files 👍🏼

[roborourke]

@robindevitt don't forget to make a new patch release if you haven't done it already!

[robindevitt]

Thanks @roborourke Got it now 👍🏼

[robindevitt]

@roborourke I may have done this incorrectly ... is a patch release the same as a tag release?

[roborourke]

No you did it right, I'll do an internal write up on semver versioning to help.