humanmade / altis-dev-tools

Dev Tools module for Altis
https://www.altis-dxp.com/resources/docs/dev-tools/
7 stars 2 forks source link

Incorrect version of Requests dependency loaded #404

Open kovshenin opened 2 years ago

kovshenin commented 2 years ago

I've been working through various PHP 8.1 related issues, and one thing I noticed is that due to a dependency is this module, WordPress core loads an incorrect version of the Requests library:

[327] => /usr/src/app/wordpress/wp-includes/class-wp-http.php
[328] => /usr/src/app/vendor/rmccue/requests/library/Requests.php

This is because class-wp-http.php calls class_exists on Requests, causing the autoloader to kick in and load the one from vendor, instead of the version shipped with WordPress core. The dependency comes from:

Acceptance criteria:

veselala commented 2 years ago

The team presented on the refinement today 17 Aug 22 roughly estimated the work need for this bug should be 5 SP. @jerico @wisyhambolu we moved this one to the Backlog.

rmccue commented 2 years ago

I think this is something WordPress needs to fix as well fwiw, we won't be the only ones hitting this issue.