search

humanmade / altis-documentation

Documentation module for Altis
https://docs.altis-dxp.com/
6 stars 3 forks source link

Host external assets locally #340

Closed shadyvb closed 2 years ago

shadyvb commented 2 years ago

Ref https://github.com/humanmade/product-dev/issues/886

roborourke commented 2 years ago

Hmm, ideally we can tell HM Linter to ignore those minified assets, may need a .phpcsignore adding.

roborourke commented 2 years ago

HM Linter doesn't seem to respect .stylelintrc or .stylelintignore which isn't very helpful. Any ideas @rmccue ?

shadyvb commented 2 years ago

The CS stuff are ongoing issues, so will merge this here, can tackle after discussion / feedback.

roborourke commented 2 years ago

Not sure what you mean there, regarding stylelint ignore support? This PR introduced the failing check but if there's no way to fix it without an update to HM Linter then it makes sense.

shadyvb commented 2 years ago

This PR introduced the failing check but if there's no way to fix it without an update to HM Linter then it makes sense.

My comment was based on yours, assumed local ignore directions wouldn't be respected by the bot. Worth revisiting, I think we're seeing this in multiple locations ( can't remember where else right now ).

roborourke commented 2 years ago

It's only the analytics plugin as far as I'm aware but that's because of the CSS copied in from the accelerate plugin.

The HM Linter readme states that the ignore files should be respected so maybe it is a bug upstream.