Update v17 documentation to note removal of GTM

mikelittle commented 1 year ago

The removal of the Analytics module from v17 also removed the GTM module. That wasn't documented, and adding back the Analytics module does not restore it

Acceptance Criteria

[x] The upgrade guide must mention the removal of the Google Tag Manager module
[x] The upgrade guide must mention how to restore the Google Tag Manager module
[x] The restore method should be tested and confirmed working

For Altis Team Use

Ready for Work Checklist

Is this ticket ready to be worked on? See the Play Book Definition of Ready

[x] Is the title clear?
[x] Is the description clear and detailed enough?
[x] Are acceptance criteria listed?
[x] Have any (potential) dependencies been identified?
[x] Is an estimate or time box assigned?
[x] Is a priority label assigned?
[ ] Is this ticket added to an epic? (Optional)

Completion Checklist

Is this ticket done? See the Play Book Definition of Ready

[x] Has the acceptance criteria been met?
[x] Is the documentation updated (including README)?
[x] Does any code/documentation meet project standards?
[ ] Are automatic tests in place to verify the fix or new functionality?
[x] Or are manual tests documented (at least on this ticket)?
[ ] Are any Playbook/Handbook pages updated?
[ ] Has a new module release (patch/minor) been created/scheduled?
[x] Have the appropriate backport labels been added to the PR?

mikelittle commented 1 year ago

This also needs a code update too. If you don't want altis/analytics, then you need to add humanmade/hm-gtm. But just doing that, it still ends up in the vendor folder. So I need to remove the installation override in vendor/altis/core/inc/composer/class-override-installer.php

mikelittle commented 1 year ago

Raised PR https://github.com/humanmade/altis-core/pull/841

mikelittle commented 1 year ago

Raised PR https://github.com/humanmade/altis-documentation/pull/553

Manual tests:

I manually added altis/analytics into a v17 project and confirmed the functionality of analytics and Google tag manager both appeared and were functional.
I manually added humanmade/hm-gtm without altis-analytics and the GTM functionality appeared and worked.

humanmade / altis-documentation