humanmade / altis-workflow

Workflow module for Altis
https://www.altis-dxp.com/resources/docs/workflow/
GNU General Public License v3.0
6 stars 3 forks source link

Add Publication Checklist summary to parent Workflow page #213

Closed ntwb closed 1 year ago

ntwb commented 1 year ago

Whilst reading the Workflow page, I noticed that the Publication Checklist wasn't referenced in this parent doc though all other sub-components are list, this PR adds that

https://docs.altis-dxp.com/workflow/

mikelittle commented 1 year ago

I just realised this PR is against the V15 branch. We removed Workflow in v14 (https://docs.altis-dxp.com/guides/upgrading/v14/#workflows-and-editorial-comments) So I'm not sure why the Workflows page is still in the public docs (I'll raise a ticket about that). This PR might not get used now, but I'll check for earlier supported versions and raise ticket or modify this if needed. Thanks for bringing this to our attention.

hm-backport[bot] commented 1 year ago

The backport to v12-branch failed:

Commits ["f7b477a7338420bae342234046d5270842d8de1c","b17d6389063876b19efdb5e47ea3b4e6b2e64b28","f1a3e5c335fc1f368ecfc97e85658d3f2acbd15b","629ac691e56d40058b4ff4ce8555e82ed48188c0","7195cdb9468c17e25be8b638ac1d09fb6ab6ca14","aef55b0fcc466bd59db8573450d4229d03977b93"] could not be cherry-picked on top of v12-branch

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v12-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick f7b477a7338420bae342234046d5270842d8de1c b17d6389063876b19efdb5e47ea3b4e6b2e64b28 f1a3e5c335fc1f368ecfc97e85658d3f2acbd15b 629ac691e56d40058b4ff4ce8555e82ed48188c0 7195cdb9468c17e25be8b638ac1d09fb6ab6ca14 aef55b0fcc466bd59db8573450d4229d03977b93
# Create a new branch with these backported commits.
git checkout -b backport-213-to-v12-branch
# Push it to GitHub.
git push --set-upstream origin backport-213-to-v12-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is v12-branch and the compare/head branch is backport-213-to-v12-branch.