search

humanmade / authorship

A modern approach to author attribution in WordPress.
GNU General Public License v3.0
66 stars 7 forks source link

Show all users in post author column. #106

Closed robindevitt closed 2 years ago

robindevitt commented 2 years ago

Related issue : https://github.com/humanmade/product-dev/issues/993

Issue

When viewing the posts screen you don't see all the authors of a given post.

Solution

The function get_author_ids wasn't returning the author ID's of all posts. This PR now shows all users in the column even when the user hasn't been assigned a role.

Steps to test

  1. Ensure you have a post where the post author is a super admin that hasn't been added to the site.
  2. Viewing all posts this will be identifiable by a post which has no author listed. It will be blank. Screenshot 2022-08-16 at 10 11 51
  3. Applying the PR allows the site to reference a user despite them having no assigned role on the site, Altis Dev is a super admin and isn't assigned to the current site with any role/s : Screenshot 2022-08-16 at 10 12 22
robindevitt commented 2 years ago

@roborourke when you get a chance please can you review my current suggested fix for this.

roborourke commented 2 years ago

Cheers both