search

humanmade / authorship

A modern approach to author attribution in WordPress.
GNU General Public License v3.0
63 stars 7 forks source link

Undocumented Node version requirements #114

Open tomjn opened 1 year ago

tomjn commented 1 year ago

Authorship specifies no Node requirements, and will fail if using modern NodeJS. To fix this the package.json should specify the range of Node versions that are supported in the engines section, and it should be mentioned in the readme file

johnbillion commented 4 months ago

It's in the .nvmrc file but nowhere else. The whole Node setup needs updating to Node 20 too.

roborourke commented 2 weeks ago

Updating to node 20 is a huge rabbit hole.

I tried making a start and I think my recommendation is a to update the build tooling to use wp-scripts instead, as well as it's eslint, stylelint and other configs. Updating the HM webpack helpers and coding standards is too difficult at this point IMO.

We will need to remove react-sortable-hoc with @dnd-kit as well because the former is no longer maintained.

johnbillion commented 2 weeks ago

As Rob pointed out, the GitHub Actions workflow for the build is not failing either, everything is green. Needs looking into.