Closed nlemoine closed 1 year ago
Sure, I didn't see you're adding composer.lock
to the repo. I'll also submit a PR in humanmade/asset-loader
to also support composer/installers
version 2
Can you merge this first?
So authorship
can actually update to composer/installers
version 2.
@nlemoine asset loader too has a composer lock file that would need updated, we'd also have to release an update for asset loader at v0.6.3 before it would be picked up here.
composer.lock
is updated on both PR. Quick question: why committing this file? It's usually discouraged.
I've pushed out v0.6.3 of asset loader
composer.lock
is updated on both PR. Quick question: why committing this file? It's usually discouraged.
I'm not 100% sure as I wasn't around when the decision was made, but I suspect it's related to it also being released on wordpress.org
( https://github.com/humanmade/authorship/pull/67 for when they were first added )
I suspect it's related to it also being released on wordpress.org
Thanks for your feedback. If your composer constraints are confidently set, this shouldn't be a problem removing it.
I updated both humanmade/asset-loader
and composer/installers
.
composer update composer/installers
should be enough to update the lock file without updating other dependencies