search

humanmade / authorship

A modern approach to author attribution in WordPress.
GNU General Public License v3.0
66 stars 7 forks source link

Add support for composer/installers 2.0 #117

Closed nlemoine closed 1 year ago

tomjn commented 1 year ago

composer update composer/installers should be enough to update the lock file without updating other dependencies

nlemoine commented 1 year ago

Sure, I didn't see you're adding composer.lock to the repo. I'll also submit a PR in humanmade/asset-loader to also support composer/installers version 2

nlemoine commented 1 year ago

Can you merge this first?

So authorship can actually update to composer/installers version 2.

tomjn commented 1 year ago

@nlemoine asset loader too has a composer lock file that would need updated, we'd also have to release an update for asset loader at v0.6.3 before it would be picked up here.

nlemoine commented 1 year ago

composer.lock is updated on both PR. Quick question: why committing this file? It's usually discouraged.

tomjn commented 1 year ago

I've pushed out v0.6.3 of asset loader

tomjn commented 1 year ago

composer.lock is updated on both PR. Quick question: why committing this file? It's usually discouraged.

I'm not 100% sure as I wasn't around when the decision was made, but I suspect it's related to it also being released on wordpress.org

( https://github.com/humanmade/authorship/pull/67 for when they were first added )

nlemoine commented 1 year ago

I suspect it's related to it also being released on wordpress.org

Thanks for your feedback. If your composer constraints are confidently set, this shouldn't be a problem removing it.

I updated both humanmade/asset-loader and composer/installers.