humanmade / authorship

A modern approach to author attribution in WordPress.
GNU General Public License v3.0
66 stars 7 forks source link

Fix pagination issue with migrate wp authors CLI command. #121

Open mattheu opened 1 year ago

mattheu commented 1 year ago

@mikelittle flagged an issue in my author migration CLI command. Because the command sets the authorship taxonomy, whilst also using a tax query with NOT EXISTS, pagination will cause blocks of users to be skipped.

More detail: after the first 100, it will query for page 2 of more posts. But because the first 100 will no longer be returned by the query, posts 200-300 get skipped.

Solution is to pass pagination param only when doing a dry run, or when overwriting for all (as in this case, no tax query is used)