search

humanmade / authorship

A modern approach to author attribution in WordPress.
GNU General Public License v3.0
66 stars 7 forks source link

Missing `lodash` dependency declaration causes error in latest version of Gutenberg plugin #136

Open goldenapples opened 11 months ago

goldenapples commented 11 months ago

Recently Gutenberg finished removing all usage of lodash: https://github.com/WordPress/gutenberg/issues/17025#issuecomment-1632633444

Because the editor scripts in Authorship still rely on lodash, but it's not declared as a dependency, they fail in the latest version of the Gutenberg plugin:

Uncaught ReferenceError: lodash is not defined

It would be good to either rewrite code that depends on lodash or declare it as a dependency.

tomjn commented 11 months ago

Looks like uses are confined to the AuthorsSelect.tsx https://github.com/humanmade/authorship/blob/develop/src/components/AuthorsSelect.tsx file