Feat add author name - Githubissues

nlemoine commented 11 months ago

Except in #139 (which is probably a typo/mistake), Authorship doesn't make use of $term->name in authorship taxonomy. This might be a good idea to store the user display name as term name and keep them in sync.

This will intriduce some nice benefits almost without any tradefoffs (at least I couldn't see a case where names could be out of sync).

I'm first trying to push this to solve a problem I'm facing with Relevanssi but could apply to any indexing technology. Since Authorship only stores IDs in terms (in both name AND slug), It's quite hard to make it index the author (display) name. With $term->name storing author display name, just mark the authorship taxonomy as "to be indexed" and you're done. Searches containing author display names will now show up in your post search results, just like it does with Co-Authors-Plus.

It would also bring more performance to get_author_names avoiding the cost of querying user objects.

Side note: it would be nice to bump your dev dependencies and drop fixed constraints, it does not play well recent PHP versions (8/8.1). PHPStan for example evolved a lot since 0.12.57 and will raise more potential problems :)

nlemoine commented 6 months ago

Friendly bump :)

I love the plugin but it really needs an update on various sides (react, php, etc.). I can contribute but need some maintainers review/merges 🙏

@johnbillion ?

johnbillion commented 6 months ago

I'm hoping to be able to arrange some time for someone to work on Authorship soon

roborourke commented 4 weeks ago

Would be a breaking change without #139, both the name and slug are the same currently. The change should be treated as breaking regardless I think so would make part of a 0.3.0 release rather than 0.2.x.

humanmade / authorship

Feat add author name #140