search

humanmade / authorship

A modern approach to author attribution in WordPress.
GNU General Public License v3.0
66 stars 7 forks source link

Add PHP8 support for composer install #83

Closed JayWood closed 2 years ago

JayWood commented 3 years ago

This adds the PHP 8 info that Chris mentions in the issue. This also bumps PHP Unit to 9.5 which supports PHP8.

Fixes #74

JayWood commented 3 years ago

Grr, looks like something borked on the testing side, will review and update 😞

johnbillion commented 3 years ago

Pretty sure you'll need to stick with PHPUnit 7, WP doesn't support 8 or 9. Info: https://make.wordpress.org/core/handbook/references/phpunit-compatibility-and-wordpress-versions/

JayWood commented 3 years ago

Yep, will give this a look after work today ( or if I catch a break ) and update. I only bumped it because it complained vigorously when I ran composer test - otherwise I would've left it alone entirely. Ty for the Doc link as well.

JayWood commented 3 years ago

@johnbillion I've reverted the phpunit back to ^7 but in order to get compose to install locally I had to --ignore-platform-reqs still - so I'm not entirely sure that will help us but maybe it will at least let tests pass?

chrisvanpatten commented 3 years ago

@johnbillion @JayWood sounds like maybe we should wait for https://core.trac.wordpress.org/ticket/46149 to land?

johnbillion commented 2 years ago

Superceded by #98