humanmade / aws-analytics

AWS Pinpoint analytics for WordPress
https://www.altis-dxp.com/
19 stars 1 forks source link

Fix insights pages #556

Closed roborourke closed 1 year ago

roborourke commented 1 year ago

Fixes issue with insights page not loading as results are semi-populated during API fetches.

Also resolves some issues with certain metrics not showing percentage symbols when they should.

roborourke commented 1 year ago

the code would break on test?.results?.variants[ variant.id ] when test.results = {}, it would try to access a non existent array. Was handled further up in the file the same way I changed it to. Not sure how it got missed at the time, been broken for ages!

hm-backport[bot] commented 1 year ago

The backport to v4-3-branch failed:

Commits ["3e6c57d8fbdbdea5c874e8fe3cc4468ca8367b32"] could not be cherry-picked on top of v4-3-branch

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v4-3-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 3e6c57d8fbdbdea5c874e8fe3cc4468ca8367b32
# Create a new branch with these backported commits.
git checkout -b backport-556-to-v4-3-branch
# Push it to GitHub.
git push --set-upstream origin backport-556-to-v4-3-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is v4-3-branch and the compare/head branch is backport-556-to-v4-3-branch.

hm-backport[bot] commented 1 year ago

The backport to v4-4-branch failed:

Commits ["3e6c57d8fbdbdea5c874e8fe3cc4468ca8367b32"] could not be cherry-picked on top of v4-4-branch

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v4-4-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 3e6c57d8fbdbdea5c874e8fe3cc4468ca8367b32
# Create a new branch with these backported commits.
git checkout -b backport-556-to-v4-4-branch
# Push it to GitHub.
git push --set-upstream origin backport-556-to-v4-4-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is v4-4-branch and the compare/head branch is backport-556-to-v4-4-branch.