search

humanmade / aws-rekognition

A lightweight plugin to add keywords to WordPress image uploads via automatic feature detection. Requires S3 Uploads.
58 stars 6 forks source link

Provide a better fallback message if Rekognition is not available #25

Closed roborourke closed 3 years ago

roborourke commented 3 years ago

Previously the spinner would show and then an error message on reload.

Fixes https://github.com/humanmade/altis-media/issues/112

Shows the following instead:

Screenshot 2021-06-21 at 15 46 32
roborourke commented 3 years ago

Yeah we could just hide it altogether, I wondered about that vs still showing that something would come up if the feature was available.

I'll update the text to your suggestion too 👍

jazzsequence commented 3 years ago

I think that if we're explicitly saying "Image recognition is not available" the implication is that there will be times when it is available. "Detected image labels: Image recognition is not available" gives the impression that there's an error or a problem when generally it's just that you're not connected to AWS services (which, I suppose, on a prod environment would be a problem, but otherwise is expected).

However, I think this is a good start and we can come back to that.