humanmade / coding-standards

Human Made coding standards for modern code
https://engineering.hmn.md/how-we-work/style/
154 stars 19 forks source link

Sniffs are not installed properly #152

Closed pdewouters closed 4 years ago

pdewouters commented 5 years ago

composer.json:

    "config": {
        "autoloader-suffix": "DontChange",
        "vendor-dir": "content/vendor"
    },
...
    "require-dev": {
        "humanmade/coding-standards": "^0.7",
        "phpunit/phpunit": "6.5"
    }

composer update:

PHP CodeSniffer Config installed_paths set to ../../automattic/vipwpcs,../../humanmade/coding-standards,../../humanmade,../../wp-coding-standards/wpcs,../../phpcompatibility/php-compatibility,../../phpcompatibility/phpcompatibility-paragonie,../../phpcompatibility/phpcompatibility-wp,../../fig-r/psr2r-sniffer

Running the sniffs

vendor/bin/phpcs --standard=humanmade/coding-standards themes/hoh-theme -s  ✔ ERROR: the "humanmade/coding-standards" coding standard is not installed. The installed coding standards are PEAR, Zend, PSR2, MySource, Squiz, PSR1, PSR12, WordPressVIPMinimum, WordPress-VIP-Go, coding-standards, coding-standards, WordPress-VIP, WordPress, WordPress-Extra, WordPress-Docs, WordPress-Core, PHPCompatibility, PHPCompatibilityParagonieRandomCompat, PHPCompatibilityParagonieSodiumCompat, PHPCompatibilityWP and PSR2R

pdewouters commented 5 years ago

Closing, as I had to add a dependency to the dealerdirect package on my project composer.json

rmccue commented 5 years ago

Hmm, annoying, that shouldn't be required I think @mikeselander?

mikeselander commented 5 years ago

No, that definitely shouldn't be required...

pdewouters commented 5 years ago

have you noticed the double coding-standards, coding-standards

pdewouters commented 4 years ago

I think this was an issue specific to this project, so closing