search

humanmade / coding-standards

Human Made coding standards for modern code
https://engineering.hmn.md/how-we-work/style/
154 stars 19 forks source link

Reconsider use of eslint-config-react-app #252

Open pdewouters opened 3 years ago

pdewouters commented 3 years ago

The react-app config doesn't seem to be updated that often and is probably very opinionated towards apps created with create-react-app

I think it makes sense to take a more generic approach and instead we could use plugin:react/recommended as a base.

Alternatively, we should probably be using https://developer.wordpress.org/block-editor/reference-guides/packages/packages-eslint-plugin/

which is the one used by Gutenberg.

svandragt commented 3 years ago 
 ├─┬ @wordpress/scripts@7.2.0
   └─┬ @wordpress/eslint-plugin@4.1.0
     └── babel-eslint@10.1.0

vs

npm WARN eslint-config-react-app@3.0.8 requires a peer of babel-eslint@9.x but none is installed. You must install peer dependencies yourself.

Using this package in combination with @wordpress/scripts results in an incompatibility.