humanmade / comment-popularity

Allow visitors to vote on comments

MIT License

25 stars 15 forks source link

Open slavicd opened 6 years ago

slavicd commented 6 years ago

If we don't allow negative comment weights (at least internally - not necessarily for user interface), we run into the following possible situation:

comment A has weight zero.
user downvotes A. A still has weight zero, but a downvote is registered per user*comment
user undoes downvote. A has weight 1.
user upvotes A. A has weight 2.

pdewouters commented 6 years ago

thanks, I was just looking into this actually - do you want to test this PR? https://github.com/humanmade/comment-popularity/pull/115

slavicd commented 6 years ago

114 I actually already submitted a PR - except perhaps it's a little bit of a different approach. Yours makes sense too