search

humanmade / comment-popularity

Allow visitors to vote on comments
MIT License
25 stars 15 forks source link

hmn_cp_v121_upgrade() breaks plugin #117

Open slavicd opened 6 years ago

slavicd commented 6 years ago

$users = get_users(); from hmn_cp_v121_upgrade() breaks for anything more than half a million users throwing out of memory error.

Moreover, the upgrade script always runs because hmn_cp_plugin_version is statically set to 1.2.0 (always)

pdewouters commented 6 years ago

thanks, I'll take a look

pdewouters commented 6 years ago

Moreover, the upgrade script always runs because hmn_cp_plugin_version is statically set to 1.2.0 (always)

It will only set the version to 1.2.0 if it doesn't find the version setting in the DB. OR do you mean on a new install?

slavicd commented 6 years ago

It would always trigger the user upgrade routine because the version would always be 1.2.0 or empty