humanmade / comment-popularity

Allow visitors to vote on comments
MIT License
25 stars 15 forks source link

Use iGrowl #90

Open pdewouters opened 9 years ago

pdewouters commented 9 years ago

Looks better than the current library in use http://catc.github.io/iGrowl/#ss-demo

willmot commented 9 years ago

The notifications seem like quite a non-standard UI when it comes to WordPress. Why not just show a more standard inline notification?

pdewouters commented 9 years ago

Are there standards for the front end other than the admin bar styles? I could just display it inline and unstyled I suppose.

mattheu commented 9 years ago

This is a difficult one. My preference as a developer would probably be inline and unstyled but then I inderstand that you want something that just works out of the box. The downside is that things come accross looking a little plugin-y

If there is any kind of standard for comment related notifications - then it probably is inline - but each theme will style individually and would be impossible to fit in - it would never be quite right.

There is no magic solution here... From what I remember - we talked about using custom events yo trigger this so it would be super easy to just dequeue this and add your own notifications. Might be worth documenting this?

pdewouters commented 9 years ago

Thanks @mattheu , that is exactly the issue. For the user, it's better to have something that looks good, but at the same time not too flashy, so it can fit in with most designs. Also, if it can be easily customized or turned off, then that would be great.

It's the same thing for the styling of the voting arrows. Right now there are no styles, and it doesn't look that great, but it doesn't clash with theme design too much. That's why I created an issue to add styles that fit in with the most popular themes.

mattheu commented 9 years ago

I think its a loosing battle trying to fit in with themes! I reckon it's best to just add something as simple and lightweight as possible and then make it really easy to disable/customise