humanmade / hm-base

Standard project layout for Human Made Projects.
81 stars 18 forks source link

Consider renaming codesniffer-ruleset.xml to phpcs.ruleset.xml #63

Closed joemcgill closed 6 years ago

joemcgill commented 6 years ago

HM Base is setting PHPCS config in a custom codesniffer-ruleset.xml ruleset file. However, this is a non-standard filename for PHPCS rulesets and doesn't automatically get picked up by linters installed in IDEs, whereas phpcs.ruleset.xml seems to be more common. Since we have to manually specify the ruleset path in our CI scripts anyway, is there any downside to a file name change?