Closed BronsonQuick closed 6 years ago
A couple things that come to my mind...
"license": "GPL-3.0-or-later"
."minimum-stability"
should be the second last (in this example file), just before "extra"
."require": { "php": ">=7.0" }
. This should be the very first entry in the "require"
section."type"
is missing/incorrect. By default, it is "library"
, but we'd want it to be "type": "project"
, right?"minimum-stability"
, by default, is "stable"
, so this is redundant. However, I'm wondering if we should have it set to "dev"
, and then, of course, also define "prefer-stable": true
...? This is what I see the most.composer.lock
file.oomphinc/composer-installers-extender
. What do we need it for? If we use mu-plugins
(see dev chat), we don't!composer-installers
supports dropins out of the box, so no need to specify that yourself (talking about Paul's comment here).// cc @fklein-lu @mikeselander @paulgibbs
Edit:
Also, maybe something like composer-normalize
would be good...
I think worrying about the precise ordering of the contents in the JSON file is obsessing too much over a tiny detail, for a base project template. If a project wanted to care about that, then they can add composer-normalize
there...
composer-installers supports dropins out of the box, so no need to specify that yourself (talking about Paul's comment here).
Except we do, because this base project has it in content/
and composer-installers
defaults to wp-content/
. :)
I don't know oomphinc/composer-installers-extender. What do we need it for? If we use mu-plugins (see dev chat), we don't!
This is because quite a few plugins and libraries don't identify themselves with a proper type or come from WPackagist which means we need a way to manually define where they're going to go. For example, Extended Template Parts registers a Composer file, but not a type.
The "minimum-stability", by default, is "stable", so this is redundant. However, I'm wondering if we should have it set to "dev", and then, of course, also define "prefer-stable": true...? This is what I see the most.
What do you recommend that we put here?
Working through these additions in #84 - Feel free to make addendums.
We've addressed all the feedback from this ticket now.
As per Mr Gibbs comment! 💖