humanmade / hm-base

Standard project layout for Human Made Projects.
81 stars 18 forks source link

Update the example composer.json #79

Closed BronsonQuick closed 6 years ago

BronsonQuick commented 6 years ago

I'd have also added "content/{$name}/": [ "type:wordpress-dropin" ] for drop-ins support, and depending on what kind of versioning schema humanmade/coding-standards uses, would have used a different versioning restrain, e.g. ~ or >.

As per Mr Gibbs comment! 💖

tfrommen commented 6 years ago

A couple things that come to my mind...

// cc @fklein-lu @mikeselander @paulgibbs

Edit:
Also, maybe something like composer-normalize would be good...

paulgibbs commented 6 years ago

I think worrying about the precise ordering of the contents in the JSON file is obsessing too much over a tiny detail, for a base project template. If a project wanted to care about that, then they can add composer-normalize there...

paulgibbs commented 6 years ago

composer-installers supports dropins out of the box, so no need to specify that yourself (talking about Paul's comment here).

Except we do, because this base project has it in content/ and composer-installers defaults to wp-content/. :)

mikeselander commented 6 years ago

I don't know oomphinc/composer-installers-extender. What do we need it for? If we use mu-plugins (see dev chat), we don't!

This is because quite a few plugins and libraries don't identify themselves with a proper type or come from WPackagist which means we need a way to manually define where they're going to go. For example, Extended Template Parts registers a Composer file, but not a type.

The "minimum-stability", by default, is "stable", so this is redundant. However, I'm wondering if we should have it set to "dev", and then, of course, also define "prefer-stable": true...? This is what I see the most.

What do you recommend that we put here?

mikeselander commented 6 years ago

Working through these additions in #84 - Feel free to make addendums.

mikeselander commented 6 years ago

We've addressed all the feedback from this ticket now.