search

humanmade / hm-base

Standard project layout for Human Made Projects.
81 stars 18 forks source link

Rename `plugins-mu` back to WordPress default. #80

Closed paulgibbs closed 6 years ago

paulgibbs commented 6 years ago

A Slack discussion raised the question of the origin of this naming convention, and we couldn't find a good reason to keep it. Reasons to change are that it is a customisation that doesn't seem to benefit the majority of our current projects, and for terminal users, it makes autocomplete a bit more frustrating.

Discussion was from https://hmn.slack.com/archives/C03K3J34A/p1536276803000100 (to ~10am UTC).

I took out some related ignores from codesniffer-ruleset.xml that no longer seem relevant; maybe they dated from pre-Platform?

Checklist

paulgibbs commented 6 years ago

I didn't have time to test and didn't want to break anything out of ignorance.

On 7 September 2018 at 16:23, Mike Selander notifications@github.com wrote:

@mikeselander commented on this pull request.

In wp-config.php https://github.com/humanmade/hm-base/pull/80#discussion_r215996178:

@@ -96,8 +96,8 @@ defined( 'WP_CONTENT_URL' ) or define( 'WP_CONTENT_URL', WP_HOME . '/content' );

// Set path to MU Plugins. -defined( 'WPMU_PLUGIN_DIR' ) or define( 'WPMU_PLUGIN_DIR', WP_CONTENT_DIR . '/plugins-mu' ); -defined( 'WPMU_PLUGIN_URL' ) or define( 'WPMU_PLUGIN_URL', WP_CONTENT_URL . '/plugins-mu' ); +defined( 'WPMU_PLUGIN_DIR' ) or define( 'WPMU_PLUGIN_DIR', WP_CONTENT_DIR . '/mu-plugins' );

Since this is now using the default path ending, do we even need to define this anymore?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/humanmade/hm-base/pull/80#pullrequestreview-153389680, or mute the thread https://github.com/notifications/unsubscribe-auth/ABN4CvjBmSFhBtgR5CWXlBs18anzHToXks5uYo9cgaJpZM4Wef3v .

mikeselander commented 6 years ago

The following lines from core appear to be the exact same as those lines so I think we can just get rid of it now.

https://github.com/WordPress/WordPress/blob/master/wp-includes/default-constants.php#L183-L194