Clean up PHPCS Ruleset - Githubissues

humanmade / hm-base

Standard project layout for Human Made Projects.

81 stars 18 forks source link

Clean up PHPCS Ruleset #81

Closed mikeselander closed 6 years ago

mikeselander commented 6 years ago

This PR cleans up and fixes several aspects of the PHPCS ruleset to bring it closer inline with our project usage.

Renames the ruleset file to phpcs.ruleset.xml: Resolves #63
Only ignore specific index.php files: Resolves #74
Use HM standards & WP Docs for ruleset: Resolves #64
Condense list of ignored directories: bonus!
Clean up our code to actually match our standards

mikeselander commented 6 years ago

As a note, I've intentionally not fixed or ignored the issues around only using namespaces in /inc. I think this is a relatively good example of why this might not be a good idea to be enforcing across the board.

mikeselander commented 6 years ago

Something (I think) unrelated around here is causing issues with CasperJS in Circle, but the tests are currently failing at the PHPCS level on older PRs anyway.

I am going to merge this PR and will open an issue to address the Casper issue.