humanmade / hm-base

Standard project layout for Human Made Projects.
81 stars 18 forks source link

Composer Additions #84

Closed mikeselander closed 6 years ago

mikeselander commented 6 years ago

Additions to the Composer file based on feedback in #79

mikeselander commented 6 years ago

@tfrommen I have no preference on the ordering so I just moved them around to match that style since it seems like it's important to you.

I also added PHP, but at a more specific versioning constraint to ensure all devs are on the same major version. I expect this to get updated to 7.2 shortly anyhow.

mikeselander commented 6 years ago

Also, I think this is ready for a final look-through unless anyone has more comments to add.

tfrommen commented 6 years ago

I have no preference on the ordering so I just moved them around to match that style since it seems like it's important to you.

Well, it is not important to me, I just thought that doing it in a standardized way was (much more) preferable than doing it just so. 🤷‍♂️ 🙂 Thanks for ordering! 😅

The PHP versions are not yet right. I'll leave in-commit comments.