search

humanmade / hm-handbook-theme

HM Handbook Theme
http://handbook.hmn.md
39 stars 9 forks source link

Public child pages of a private page incorrectly show the padlock in the main nav #120

Open willmot opened 2 years ago

willmot commented 2 years ago

To reproduce

  1. Create a private page and add to main nav
  2. See that it correctly has a padlock in the nav link
  3. Create a public child page
  4. See that it incorrectly has a padlock in the nav link

This is impacting both the COVID-19 section and the Company Structure sections both of which are private sections which do contain some public child pages.

Screenshot 2021-11-12 at 13 07 06

Expected Result

Don't show padlock on public pages which are a child of a private page

Looks like the issue is the CSS selector which is adding the padlock, currently targets li.private a instead of li.private>a