Search - Githubissues

humanmade / hm-handbook-theme

HM Handbook Theme

http://handbook.hmn.md

39 stars 9 forks source link

Search #40

Closed mattheu closed 8 years ago

mattheu commented 8 years ago

live search. Uses the same code for live search as hub.hmn.md. I copy-pasted most of it. Falls back to normal WP_Query if the elastic search plugin is not activated.

sambulance commented 8 years ago

Given it a once over but maybe get another pair of eyes before merging :)

mattheu commented 8 years ago

@sambulance I've added a little more to this PR.

Display a title on the real search results page for non-JS fallback.
Add pagination to index pages just in case you ever end up hitting these.

mattheu commented 8 years ago

maybe get another pair of eyes before merging :)

If you think it looks OK i'm happy to merge! Just good to get someone to sanity check it a little :)