search

humanmade / hm-handbook-theme

HM Handbook Theme
http://handbook.hmn.md
39 stars 9 forks source link

Install and style plugin for inline commenting #68

Closed libby-barker closed 7 years ago

libby-barker commented 7 years ago

This commenting will be used to gather feedback from public

mattheu commented 7 years ago

I'm going to propsoe we close this issue as a duplicate of https://github.com/humanmade/hm-handbook-theme/issues/10.

I originally decided that whilst it's a nice to have, this needn't be a blocker to the public release. I implemented standard comments instead.

If someone wants to tackle this, then great. However I'd like to see it done well. The old handbook just used a plugin but I didn't think it was great and was pretty buggy. Perhaps there are alternatives approaches as I realize doing something custom is a fair bit of work?

cc @missjwo Does this sound OK or do you think its a requirement?

mattheu commented 7 years ago

Additionally, I think we discussed having comments closed/hidden from the public, and instead drive questions to us via different channels.

I also think it would be confusing to have both internal and external comments on this.

Perhaps we need to discuss this further.