search

humanmade / hm-platform

HM Hosting platform required plugins
https://engineering.hmn.md/platform/plugins/
23 stars 4 forks source link

Add Query Monitor #2

Open joehoyle opened 8 years ago

joehoyle commented 8 years ago

It might be cool if all sites on our hosting had query monitor, that would only be enabled if something like ?query_monitor=true for only people on the poxy or something.

rmccue commented 8 years ago

I'd be down for this, wondering if there's anything that could go badly though by dynamically loading/unloading QM.

In any case, I think either just the proxy status or proxy + a cookie would be better than a GET param, and less likely to cause problems too.

rmccue commented 8 years ago

We also have to consider: is this something we want on client sites permanently? It is a bit out of the scope of hm-platform really, since it's not base functionality.

noeltock commented 7 years ago

Related https://platform.hmn.md/2017/04/28/platform-from-the-ground-up-heres-some-thoughts/

nathanielks commented 7 years ago

In any case, I think either just the proxy status or proxy + a cookie would be better than a GET param, and less likely to cause problems too.

Yup yup yup.

nathanielks commented 7 years ago

We also have to consider: is this something we want on client sites permanently? It is a bit out of the scope of hm-platform really, since it's not base functionality.

Would we have a separate package then? I see hm-platform's responsibility not only for functionality but also the components that makes our platform our platform. Perhaps it'd be a part of a developer support package or something?

fklein-lu commented 6 years ago

People from HM that work on the sites should have a special role (HM Support), and for that role you add the required capability to view QM.

rmccue commented 6 years ago

I think gating it via the proxy is probably an easier way to do it, and doesn't require deep hooking into WP.