search

humanmade / hm-time

6 stars 3 forks source link

Code Review #6

Closed willmot closed 8 years ago

willmot commented 10 years ago

Let's get some code-review on this so we can wrap up @missjwo's trial.

@joehoyle could you give this a run through?

As everything's been committed direct to master it's probably easiest to use the compare view: https://github.com/humanmade/hm-time/compare/305da862481a7594eacc7196b2f45c113a08d525...master#diff-5a919bd866b1582bea1e73be5843d3ccR234

missjwo commented 10 years ago

Hi @willmot @joehoyle,

I've just dismantle bits to add in the API stuff. You are more than welcome to look at the code but i really thing if you hold off a day and half so I can finish the API tomorrow, and clean up the mess i've left in its wake.

You probably will need some documentation as you need a Foursquare App, the Maxmind API details and a Google Apps key for their timezone api as well as a updated version of the salty stack i am using - it allows for https via vagrant share.

I know you guys are keen to review but I really don't want to waste your time.

In fact, as i write this i've forked a copy out and going to return this master copy to the last working version so if you really want to review, you can. Be warned some stuff is in the themes header so I could test the Foursquare push API without writing the api first and there's next to no OO.

I'll work on my forked copy tomorrow and then just do a PR so that you guys can see what I really want you to see. :)

Jen

willmot commented 10 years ago

We can wait :-)

missjwo commented 10 years ago

Smart move :) Have a good night. I'm off to bed.