`X.Y` versioning in config file fails

humanmade / linter-bot

Automatically run the HM Coding Standards on any repository.

16 stars 3 forks source link

`X.Y` versioning in config file fails #106

Open pdewouters opened 5 years ago

pdewouters commented 5 years ago

On the github PR checks tab, I clicked rerun and it failed Could not run: Error: Could not fetch https://make.hmn.md/hmlinter/standards/eslint-0.6.tar.gz: 403 undefined

pdewouters commented 5 years ago

The repo has a custom config:


# GLOBAL SETTINGS

# By default, the version is set to "latest". This can be set to any version
# from 0.4.2 and above, but you MUST include the full version number.
# If you wish to increase the security releases automatically set the
# version to be 'X.Y', otherwise it will be 'X.Y.Z'.
version: 0.6

# PER-STANDARD SETTINGS
phpcs:
  # Set to false to disable phpcs
  enabled: true

  # Set to "inherit" to use the global version, "latest" for the latest
  # version, or a specific full version number.
  version: inherit

eslint:
  enabled: true
  version: inherit```

mikeselander commented 5 years ago

It looks like the comment allowing for X.Y is wrong and it's only looking for the major/minor version which we don't publish.

Including an example request here:

Request details
GitHub Event ID: dcaba820-781e-11e9-95e6-002bf1866f37
API Gateway ID: dcec33a6-781e-11e9-80fe-93f08d8a0e11
Lambda ID: 960f1f6a-6b83-490b-b51f-8e16f8231070
Log Stream: 2019/05/16/[$LATEST]753e2594a796468bba66c3cce247d5c6

FYI I updated the title to better reflect the issue Paul. I suspect you merged the config in between runs on this particular PR which made it look like a re-run issue.