humanmade / linter-bot

Automatically run the HM Coding Standards on any repository.
https://github.com/apps/hm-linter
16 stars 3 forks source link

Split out core functionality #114

Open rmccue opened 4 years ago

rmccue commented 4 years ago

To allow for greater configurability and reuse, I'd like to split the following pieces out into separate packages:

Ideally, I'd like to switch this repo over to a Lerna repo so we don't have to faff about with synchronising packages everywhere, and so that this is basically just a minor internal refactor. I'll need to test that this is working properly with our complex AWS deployment system though.

@mikeselander before I start on this, any objections?

rmccue commented 4 years ago

Part of splitting this out would allow us to potentially offer easier ways to run the linter locally, e.g. npx @humanmade/linter.

mikeselander commented 4 years ago

I have no general objections, but I'm also not sure I understand why you'd like to make the split along those lines. Will our next linter bot not be a Probot and you'd like to keep the linter-core code available to another type of checker?

rmccue commented 4 years ago

I'd like to make the linting available for two further purposes:

Beyond that, for the code review stuff I'm working on (see issue linked above), the Probot functionality may need to differ from hm-linter. Rather than making linter-bot infinitely adaptable to try and make that work, splitting into packages should allow that flexibility.

mikeselander commented 4 years ago

Got it, thanks for the added clarity! Running these locally would be a huge boon 💯