Open rmccue opened 4 years ago
Part of splitting this out would allow us to potentially offer easier ways to run the linter locally, e.g. npx @humanmade/linter
.
I have no general objections, but I'm also not sure I understand why you'd like to make the split along those lines. Will our next linter bot not be a Probot and you'd like to keep the linter-core
code available to another type of checker?
I'd like to make the linting available for two further purposes:
Beyond that, for the code review stuff I'm working on (see issue linked above), the Probot functionality may need to differ from hm-linter. Rather than making linter-bot infinitely adaptable to try and make that work, splitting into packages should allow that flexibility.
Got it, thanks for the added clarity! Running these locally would be a huge boon 💯
To allow for greater configurability and reuse, I'd like to split the following pieces out into separate packages:
src/linters/
directory into a new@humanmade/linter-core
packagesrc/format.js
andsrc/hooks.js
into a new@humanmade/linter-github
package (and maybe some other bits too)Ideally, I'd like to switch this repo over to a Lerna repo so we don't have to faff about with synchronising packages everywhere, and so that this is basically just a minor internal refactor. I'll need to test that this is working properly with our complex AWS deployment system though.
@mikeselander before I start on this, any objections?