search

humanmade / linter-bot

Automatically run the HM Coding Standards on any repository.
https://github.com/apps/hm-linter
16 stars 3 forks source link

Add PHP binary build script #162

Open roborourke opened 2 years ago

roborourke commented 2 years ago

Uses Dockerfile suggested by Joe on #161 to generate PHP binaries. I'm not sure if we should just commit the binaries here as they have to be downloaded when building the lambda anyway. We could get maybe 3 binaries in within the 512mb limit for function size.

Usage: npm run build:php -- <version>

<version> needs to be a fully qualified version number as it's used to match the PHP source tarballs on GitHub.

joehoyle commented 2 years ago

I think not committing them, and uploading them to s3 is still the way to go.

kadamwhite commented 2 years ago

@joehoyle asked in Slack today what version of PHP is used here. It's whatever is in s3://hm-linter/bin, which probably isn't 7.4. If we don't merge this, how do we validate the version used there, and update it accordingly?

roborourke commented 2 years ago

The PHP version currently available and in use is 7.1.

This addition makes it easy to generate binaries for different versions so far but needs to support a configuration option. We may be able to forgo this in favour of just updating the binary and having the config option set a runtime flag for the PHP version 🤔

roborourke commented 2 years ago

Actually the script is still useful but we don’t necessarily need more than one binary available as long as it’s the latest.

joehoyle commented 1 year ago

This looks great, I also modified the script to also export lib files that are required to run the PHP binary. I'm able to verify the binary works in lambda by running:

docker run --platform linux/amd64 -it --rm --entrypoint /bin/bash -v $PWD:/var/task  public.ecr.aws/lambda/nodejs:12
php -v

This was a PHP 8.2 build. I haven't verified that phpcs all runs correctly though under 8.2 yet.

joehoyle commented 1 year ago

Agree that I think we just want to use the latest version of PHP, rather than supporting multiple versions; if that can work anyway.

joehoyle commented 1 year ago

Need to work out how to run these damn tests. I think we might have a hodgepodge of older tests that might not even work

joehoyle commented 1 year ago

@roborourke if you have any availability any chance you could try work out how to run the tests and get this shipped? I'm a bit snowerd under atm.

joehoyle commented 10 months ago

FYI we're still running 7.1.9 here!