search

humanmade / plugin-tester

Simple Docker image for running unit tests for WordPress plugins
21 stars 2 forks source link

Synchronise wp-phpunit and WordPress versions #7

Open johnbillion opened 4 years ago

johnbillion commented 4 years ago

wp-phpunit is hardcoded to version 5.4.0 in Dockerfile.

This should be synchronised with WP_VERSION to avoid potential issues when running WordPress against an older version of its test suite, primarily PHP notices, deprecated notices, and just plain bugs.

tarecord commented 4 years ago

It seems that the WordPress archive and wp-phpunit use different versioning methods. On a major release, the WordPress archive trims the trailing 0:

https://wordpress.org/wordpress-5.4.tar.gz
https://github.com/wp-phpunit/wp-phpunit/archive/5.4.0.tar.gz

Would it make sense to add both versions?

ARG WP_VERSION=5.4
ARG WP_PHPUNIT_VERSION=5.4.0