Fix issues with translations not working

humanmade / post-cloner

Post Cloner plugin

3 stars 2 forks source link

Fix issues with translations not working #21

Closed stuartshields closed 4 years ago

stuartshields commented 4 years ago

@mikeselander This PR does the following:

Updates translation support for Gutenberg 5.*
Adds in sprintf for use with __

Code to run to generate language files:

wp i18n make-pot . post-cloner-ja.po --domain=post-cloner

wp i18n make-json post-cloner-ja.po --no-purge

@abhishek-kaushik Can you please test these changes locally. After running the make-json command above you should now get Success: Created 1 file.

stuartshields commented 4 years ago

hmlinter issues are addressed in PR #20

mikeselander commented 4 years ago

@stuartshields thanks for adjusting that - normally I would prefer the spreading but since we don't have a Babel pipeline it's better to make it support all browsers by default. We should probably add a build pipeline at some point if there's greater appetite to support Gutenberg.