Open rmccue opened 6 years ago
ping @kadamwhite @igmoweb @tfrommen for thoughts
This is ready to go, so time for review! 😁
@kadamwhite Ever get a chance to review this? :)
@kadamwhite Ping :D
I'm unable to test this because no matter what I do with npm link
, during the npx create-react-wp-plugin
step the project blows up because new-plugin/node_modules/react-wp-scripts/scripts/init-extra.js
is missing. If you have working steps for how to test, please advise.
Merge conflicts also need to be addressed. I know that's my fault for delaying in my review, but if you can update then I'll prioritize this.
@kadamwhite Would this command work?
create-react-app --scripts-version git+https://git@github.com/humanmade/react-wp-scripts.git#init-commands .
Latest CRA version allows you to specify --scripts-version file:path/to/my-scripts
Fixes #24.
@humanmade/create-react-wp-project
, the common core of the commands; andcreate-react-wp-plugin
andcreate-react-wp-theme
, the user-facing commandsreact-wp-scripts.php
toloader.php
plugin.php
for plugins orfunctions.php
andstyle.css
for themes to create a minimal plugin/themeTo do:
react-wp-scripts
instead of temporary file reference