humanmade / react-wp-scripts

Integrate create-react-app with your WordPress theme/plugin.
235 stars 32 forks source link

Add standalone commands #26

Open rmccue opened 6 years ago

rmccue commented 6 years ago

Fixes #24.

To do:

rmccue commented 6 years ago

ping @kadamwhite @igmoweb @tfrommen for thoughts

rmccue commented 6 years ago

This is ready to go, so time for review! 😁

rmccue commented 6 years ago

@kadamwhite Ever get a chance to review this? :)

rmccue commented 5 years ago

@kadamwhite Ping :D

kadamwhite commented 5 years ago

I'm unable to test this because no matter what I do with npm link, during the npx create-react-wp-plugin step the project blows up because new-plugin/node_modules/react-wp-scripts/scripts/init-extra.js is missing. If you have working steps for how to test, please advise.

Merge conflicts also need to be addressed. I know that's my fault for delaying in my review, but if you can update then I'll prioritize this.

igmoweb commented 5 years ago

@kadamwhite Would this command work?

create-react-app --scripts-version git+https://git@github.com/humanmade/react-wp-scripts.git#init-commands .

roborourke commented 5 years ago

Latest CRA version allows you to specify --scripts-version file:path/to/my-scripts