Development socket connects to incorrect host

humanmade / react-wp-scripts

Integrate create-react-app with your WordPress theme/plugin.

235 stars 32 forks source link

Development socket connects to incorrect host #69

Closed rmccue closed 3 years ago

rmccue commented 3 years ago

The development socket appears to use window.location.host, so attempts to connect to e.g. https://vagrant.local/sockjs-node/info?t=1609278734724 instead of the correct host.

The old version of react-wp-scripts had a specific workaround for this IIRC.

rmccue commented 3 years ago

Tracked it down; it's due to node_modules not always being hoisted. PR incoming.