humanmade / smart-media

Smart Media enhancements for WordPress
83 stars 7 forks source link

Clicking image in featured image selection opens the modal in library view #127

Closed roborourke closed 3 years ago

roborourke commented 3 years ago

Once a featured image has been selected, saved and then page refreshed, clicking on the featured image itself will open the media modal in the library view rather than having the featured image selected.

This is a bit confusing because before a page refresh the media modal state is what you would expect.

Reported by @abhishek-kaushik

roborourke commented 3 years ago

This issue actually persists in WP versions < 5.6. Must be some difference in how Gutenberg handles the featured image settings.

miteshpandey commented 3 years ago

@roborourke: We've tested this on Altis v7, and it doesn't seem to work. Any suggestions?

roborourke commented 3 years ago

Hi @miteshpandey, can you confirm which version of smart media is running? You can find it under the Altis Logo menu dropdown in the admin bar, go to the "About" page, then the "Credits" tab and look for humanmade/smart-media

miteshpandey commented 3 years ago

@roborourke : humanmade/smart-media (0.3.9)

roborourke commented 3 years ago

@miteshpandey if this a priority for your project ideally someone on the project team can take a look into it. In terms of Altis development this isn't a high priority in the backlog currently.

miteshpandey commented 3 years ago

Thanks @roborourke Yes, it's a very high priority at the moment. There's a feature which is getting affected by this issue. As informed to us previously, we were under the impression that updating to Altis v6 will resolve this. However, we updated straight to v7 from v5 (due to some business decisions) and don't see this resolved on its own. Client is waiting for this to be resolved asap. Thanks for your help :)

roborourke commented 3 years ago

@miteshpandey are you able to expand more on the feature getting affected by it? Is there some project code interacting with the media modal too?

miteshpandey commented 3 years ago

@roborourke : Here's the feature description:

When a featured image is already specified in a post, clicking on it shows up media library. Editors want to crop a photo that is already specified as a featured image, but it's hard to find it in the media library. Editors are stressed because this site has a lot of images and it is difficult to find the featured image of an article later. They want the CMS to take them to the respective image editing screen when clicked on the featured image.

For more technicality, I'll ask the engineer on the project @skswong8 to get in touch tomorrow (he's afk now).

miteshpandey commented 3 years ago

@roborourke: Do you need any more assistance? Are we able to prioritise this on high priority?

rmccue commented 3 years ago

@miteshpandey Please keep any client-specific conversations to Slack, this is not the place to have these discussions.

roborourke commented 3 years ago

This bug was fixed but still occurs due to an incompatibility with the Google AMP plugin. Fixed by #158

roborourke commented 3 years ago

The compatibility issue was fixed in this plugin so closing out again.