search

humanmade / smart-media

Smart Media enhancements for WordPress
82 stars 7 forks source link

dependency upgrade #188

Open dkress59 opened 2 years ago

dkress59 commented 2 years ago

Hi there,

I've been trying to fix an issue we've been having with the plugin at work (#187). I did not succeed in fixing the issue, but maybe you'd like to merge the upgraded dependencies? I'm only opening the PR so that maybe not all of my work on this plugin has been for nothing.

I replaced node-sass with dart-sass, because node-sass was causing an error during installation on my machine – in my experience dart-sass (npm:sass) is way more reliable, anyway, especially in combination with webpack/sass-loader. Also I replaced the deprecated @babel/polyfills package with core-js as recommended in the babel documentation, while sticking to your defined browser target. Also the "^" were removed from the package.json so that one does not have to look into the package-lock.json in order to find out the exact installed versions – I can, of course, change that back for you, if you don't like it.

dkress59 commented 2 years ago

In another run, today, I replaced the use of jQuery.

I also tried replacing the version of imgareaselect with the one from WP v.5.5.9, but that didn't help my issue, either.

Brickphilla commented 2 years ago

Looks like this is also would solve my problem. Any update on this?

roborourke commented 1 year ago

It should be using whatever version of imgareaselect is bundled with WP, I thought it had the appropriate compat but perhaps not.

I think at this point it'd be ideal to look at removing the jQuery dependency altogether.

dkress59 commented 1 year ago

@roborourke jQuery already has been removed in this PR 😃

roborourke commented 1 year ago

🤦 sorry, code blind today clearly!

dkress59 commented 1 year ago

😄 happens to the best!