search

humanoid-colors / emacs-humanoid-themes

Light and dark theme with bright colors for Emacs that supports GUI and terminal
GNU General Public License v3.0
70 stars 7 forks source link

Face when scheduling Org Mode event is invisible #1

Closed mankoff closed 4 years ago

mankoff commented 4 years ago

To replicate, make an * Org Heading and then C-s and then +1 to schedule 1 day in the future. The minibuffer should show the selected date (today + 1 day), but does not.

Screenshot of humanoid-light:

humanoid

Screenshot of a different theme loaded /after/ humanoid so things might look a bit weird.

kaolin

tasmo commented 4 years ago

Thank you for writing this issue.

I tested it in Spacemacs and Doom and got results with the expected display in the minibuffer: Screenshot from 2020-01-17 11-42-47

So I'm not sure where to look.

ogdenwebb commented 4 years ago

Org-mode doesn't have a dedicated face for this part of minibuffer though, so org-mode uses secondary-selection face here.

mankoff commented 4 years ago

From Emacs Manual

You can control the appearance of the highlighting by customizing the secondary-selection face (see section AD.2.2.3 Customizing Faces).

But I'm not yet sure what to do with that information.

tasmo commented 4 years ago

The background for the secondary-selection-face is defined here: https://github.com/humanoid-colors/emacs-humanoid-themes/blob/master/humanoid-themes.el#L231 As the foreground is not defined it inherits the foreground from the face before.

Can you try to unload all other themes before activating humanoid-light?

mankoff commented 4 years ago

Huh. Yes on a clean install there is no issue. I apologize, I thought I tested it without loading any other themes first.